chore: modern C# — GeneratedRegex, sealed classes (#313 partial) - #369
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (6)
📝 WalkthroughWalkthroughSix service classes are refactored to improve encapsulation and performance: NetworkRepairService, PerformanceService, PowerShellRunner, and SystemInfoService are sealed to prevent inheritance. AppBlockerService and ServiceManagerService are additionally converted to sealed partial classes with source-generated regex patterns replacing inline regex validation calls. ChangesService Class Sealing and Regex Code Generation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
3 tasks
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
Add CHANGELOG entries for four releases from the code audit sessions: - **v0.28.10**: Critical fixes (deadlock, COM leak, 50MB alloc, input validation) - **v0.28.11**: ViewModel lifecycle cleanup (IDisposable, event handlers, fire-and-forget) - **v0.28.12**: CodeQL catch-of-all-exceptions (12 files, ~22 alerts) - **v0.28.13**: CodeQL remaining (DuplicateFileService, App.xaml.cs, StartupService) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues #313 (Modern C#). Addresses MODERN-001 and MODERN-005.
Changes
MODERN-001: GeneratedRegex
MODERN-005: sealed classes
None of these classes are inherited anywhere in the codebase.
Remaining for #313
No release triggered
chore: prefix — no version bump.
Summary by CodeRabbit